Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • ketos ketos
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • public_projects
  • ketosketos
  • Merge requests
  • !263

Merged
Created Sep 02, 2022 by Oliver Kirsebom@kirsebomOwner

Rolling back changes in load audio

  • Overview 5
  • Commits 8
  • Pipelines 7
  • Changes 10

I was unhappy with some of the changes that had been made to the load_audio method in this recent merge which I did not have the opportunity to review, so I have created this new branch where the changes are rolled back.

In particular, I was unhappy with the new interface of the load_audio method which requires the user to specify the representation class when the data is loaded. This is in my view not a great solution since it would allow the user to specify a class inconsistent with the data that is being loaded. For example, the data saved to the database may be a Waveform in which case it makes little sense to specify the class as MagSpectrogram.

The idea behind the design of the write and load functions in the database_interface module is that the presentation information (class as well as parameters) gets saved to the database along with the data, so that the objects can be recreated automatically with all the correct properties.

If you think this is a bad idea, I'd like to understand why. Thanks!

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: rolling_back_changes_in_load_audio