Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • ketos ketos
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • public_projects
  • ketosketos
  • Issues
  • #155

Closed
Open
Created Jan 13, 2022 by Oliver Kirsebom@kirsebomOwner

Consistent naming of arguments (frame vs. duration)

The AudioFrameLoader uses the argument frame to specify the waveform/spectrogram duration: https://gitlab.meridian.cs.dal.ca/public_projects/ketos/-/blob/master/ketos/audio/audio_loader.py#L446 Everywhere else in ketos (e.g. in the audio representation config file) we use the term duration to refer to the same thing. To avoid confusion (see e.g. #154 (closed)), we should use the same name everywhere.

Suggestion: Add a duration argument to the AudioFrameLoader. Keep frame for the time being for backward compatibility. If the user specifies both, ignore the value specified for frame while issuing a warning/info message.

@bpadovese does this sound like a good solution to you?

Edited Jan 13, 2022 by Oliver Kirsebom
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking