Consistent naming of arguments (frame vs. duration)
The AudioFrameLoader uses the argument frame
to specify the waveform/spectrogram duration:
https://gitlab.meridian.cs.dal.ca/public_projects/ketos/-/blob/master/ketos/audio/audio_loader.py#L446
Everywhere else in ketos (e.g. in the audio representation config file) we use the term duration
to refer to the same thing.
To avoid confusion (see e.g. #154 (closed)), we should use the same name everywhere.
Suggestion: Add a duration
argument to the AudioFrameLoader. Keep frame
for the time being for backward compatibility. If the user specifies both, ignore the value specified for frame
while issuing a warning/info message.
@bpadovese does this sound like a good solution to you?
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information