Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • ketos ketos
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • public_projects
  • ketosketos
  • Issues
  • #133

Closed
Open
Created Nov 11, 2021 by Oliver Kirsebom@kirsebomOwner

Possible problem with implementation of group_detections

In the current implementation of the group_detections, the duration of a grouped detection event can be shorter than the length of a single spectrogram sample if the samples are overlapping in time. For example, if a spectrogram with start=5.0s and duration=3.0s triggers a detection, but the subsequent spectrogram starting at start=5.5s does not trigger a detection, the grouped detection event is assumed to begin at start=5.0s and have a duration of only 0.5s. This is reflected in this unit test:

https://gitlab.meridian.cs.dal.ca/public_projects/ketos/-/blob/master/ketos/tests/neural_networks/test_detection.py#L198

However, as far as I can tell this constraining effect is only implemented for later samples, not earlier ones. In the above unit test, for example, the spectrogram sample starting at 4.5s and ending at 7.5s does not trigger a detection, yet the grouped detection event returned by the group_detection function still starts at 5.0s. Isn't this an inconsistent treatment of future and past, so to speak?

Infact, if we were to treat earlier negatives on par with later ones, the grouped detection event in the unit test would be have to be discarded altogether.

@fsfrazao , your thoughts?

Edited Feb 03, 2022 by Oliver Kirsebom
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking