Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • kadlu kadlu
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 17
    • Issues 17
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • public_projects
  • kadlukadlu
  • Merge requests
  • !32

Merged
Created Feb 06, 2020 by Oliver Kirsebom@kirsebomOwner

ocean module : mostly restructuring but also some changes to implementation

  • Overview 4
  • Commits 25
  • Pipelines 13
  • Changes 22

Hi @matt_s , you can take a look at this whenever you have time. No rush.

As I mentioned, I have made some changes to the Ocean class, mostly in terms of structure, but also some changes to functionality. I have also updated the unit test suite for the Ocean class, with all tests currently passing.

Going forward, I suggest that we put more focus on building and maintaining a comprehensive test suite. (This is not a criticism of your work, by any means, but rather a natural and timely change in our workflow, now that the package is starting to come together!)

When you sit down to review the changes I have made to the Ocean class, I would recommend starting with the unit tests, as these illustrate the intended behaviour.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ocean_module_uniform