Skip to content

GitLab

Closed
Created by Oliver Kirsebom@kirsebomOwner3 of 3 tasks completed3/3 tasks

Review of feature/output_database

Hi @xuhui_liu . Upon a quick inspection, I think this looks good. Some suggestions:

  1. Give the out.py file a more descriptive name, e.g., output_database.py

  2. Use the same docstring style as the rest of the Kadlu, see for example: https://gitlab.meridian.cs.dal.ca/public_projects/kadlu/-/blob/feature/output_database/kadlu/geospatial/data_sources/hycom.py#L129

  3. Create unit tests to check that the methods are working as intended.

Edited by Xuhui Liu
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information