Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • ketos ketos
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • public_projects
  • ketosketos
  • Merge requests
  • !252

Merged
Created Jun 16, 2022 by Bruno Padovese@bpadoveseOwner

Fix select function when annotaiton start and end times have incorrect values

  • Overview 0
  • Commits 6
  • Pipelines 4
  • Changes 3

If an annotation had incorrect values for start and end time, the time_shift function in the selection_table module would enter an infinite loop.

This happened when start time was bigger than end time. For example this line in the annotation of the tutorial:

start end label sound_file datetime
3054 899.1548 0.596399999999903 upcall NOPP6_EST_20090328_004500.wav 2009-03-28 00:45:00

The fix now skips the annotation and doesnt create any segments with it. It gives a warning indicating the annotation filename and start and end time.

In addition, added an assertion for the time_shift function to check the length argument.

This resolves the issue found with the ketos_tutorial ketos_tutorials#3 (closed) (Although the values in the table are still incorrect)

Now, the curios thing is, this entry was present before. So who knows what the select function was doing before :)

Edited Jun 17, 2022 by Bruno Padovese
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix_select_func_value_error_handling