Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • ketos ketos
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • public_projects
  • ketosketos
  • Issues
  • #86

Closed
Open
Created Dec 19, 2019 by Bruno Padovese@bpadoveseOwner

naming style and standardize names and variable

  • When applicable, change variable names to confirm with snake_case naming convention. For example, in the Spectrogram module, someone not familiar with the code can read flow as literally the word flow, instead of f_low, or thigh instead of t_high. But it is not applicable everywhere, for example lets use df instead of d_f.
  • Standardize some methods and names throughout the code. For example:
  1. In the MagSpectrogram class, we have a method called from_wav that has a decibel=True argument as default. However the class constructor has a decibel=False as default, resulting in two different spectrograms if the user is not careful, and it is not immediately obvious. (Also, is the from_wav method even needed? seems like it does the same thing as the class constructor).
  2. In the same MagSpectrogram class and from_wav method, we have arguments called winlen and winstep in the constructor and window_size and step_size in the method.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking