kedgi issueshttps://gitlab.meridian.cs.dal.ca/public_projects/kedgi/-/issues2020-05-29T01:36:38Zhttps://gitlab.meridian.cs.dal.ca/public_projects/kedgi/-/issues/6Issues to be addressed before release2020-05-29T01:36:38ZOliver KirsebomIssues to be addressed before releaseHi @xuhui_liu , I have reviewed the Kedgi app. Good work. Please take some time to fix the issues listed below. Thanks.
1. [x] In the environment files, change the environment name from adi_env to kedgi_env. Remember to also change th...Hi @xuhui_liu , I have reviewed the Kedgi app. Good work. Please take some time to fix the issues listed below. Thanks.
1. [x] In the environment files, change the environment name from adi_env to kedgi_env. Remember to also change the name in run_app.sh, the readme file, the doc files, and everywhere else the name is used.
2. [x] The repository takes up almost 500 MB! Why is it so large? Would be good to reduce the size considerably.
3. [x] Under settings -> advanced, change the path of the project from acoustic_detector_interface to kedgi.
4. [x] The readme file should start with a high-level introduction to the app, which explains what the purposes of the app is, etc. Also, this first paragraph should contain a link to the sphinx docs. For inspiration, see for example the readme file of Kadlu or Ketos. (The same high-level intro can be used in the sphinx docs)
5. [x] The paragraph describing how to run the app also contains installation instructions, which belong in the previous paragraph. Please separate correctly.
6. [x] In the sphinx docs, I would suggest to separate the two tutorials into two separate pages. Also I would make it more clear that the first tutorial is for users, whereas the second tutorial is for developers.
7. [x] Is the data folder needed? It only contains a single file called grunt.csv.
8. [x] I cannot find the toy_detector_1.zip file.
9. [x] Does the docs/build folder need to be included in the repository? I do not think so ...
10. [x] In the sphinx docs, I would replace 'Platform of underwater acoustic detections and classifications models' with 'Graphical interface for acoustic detectors' or something along those linesXuhui LiuXuhui Liu